reflux/refluxjs

Reflux stores don't play nice with webpack Hot Module Replacement

Open

#385 创建于 2015年7月31日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)JavaScript (5,377 star) (354 fork)batch import
enhancementhelp wanted

描述

If have simple application using Reflux and everything works properly. I'm using webpack to build and run everything with HMR support. The react components get hot swapped properly and also the Actions and Stores get hot swapped. The only problem is the 'old' Store is still active and still reacting to the Actions. So every compile that changes something in a Store, you end up with another version of the Store.

Is there something that can be done to fix this?

贡献者指南

技术栈
javascriptreact
领域
frontenddeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Reflux store lifecyclewebpack HMRJavaScript closures
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
Investigate how Reflux stores register with actions. Likely a cleanup mechanism is missing on module replacement. Look at Reflux's Store.js to see how listeners are attached and consider using webpack's module.hot.dispose to detach old stores. Review existing comments for any suggested approaches.