redux-utilities/redux-actions

Should print warning message if type is undefined

Open

#86 创建于 2016年5月6日

在 GitHub 查看
 (7 评论) (1 反应) (1 负责人)JavaScript (6,540 star) (340 fork)batch import
help wanted

描述

Consider this code, it's commonly used in my project:

import * as actionTypes from './actionTypes.js'
export default handleActions({
  [actionTypes.ACT_1]: (state, action) => {},
  [actionTypes.ACT_2]: (state, action) => {},
})

If there's a typo in actionTypes variable(ACE_1 for instance), there's no warning, linters can't tell the error too. But it's easy to print warning message using redux-actions.

I'd like to send a PR if it's okay to you.

贡献者指南

技术栈
javascript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptRedux conceptsredux actions library
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue requests adding a warning when an action type is undefined. Likely the change should be made in the handleActions function, which processes the action map. Check the source code for where types are resolved, and add a console.warn when a type resolves to undefined. No existing PR or assignee activity, so you may start by reviewing the handleActions implementation and proposing a simple warning.