recloudstream/cloudstream

Improve delayed updater triggering method

Open

#1,282 创建于 2024年8月16日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)Kotlin (9,642 star) (877 fork)batch import
enhancementgood first issue

描述

Describe your suggested feature

Currently actually updating is done in onPause() in MainActivity, this causes inconsistent and unexpected triggering behavior. I suggest we move this to onDestroy() And add a persistent notification that says something like "Update now" on mobile, and auto stop app when you click update on TV. This is because onPause() is also triggered when you enter PiP mode or switch activities such as going to "Manage Accounts". I understand the reason for waiting is for user choice but the current implementation I don't think actually indicates "user choice" as if you forget about it or something and go home you inadvertently start the update which force stops the app. To me, this is bad behaviour.

Other details

No response

Acknowledgements

  • My suggestion is NOT about adding a new provider
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

贡献者指南

技术栈
kotlinandroid
领域
mobile
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Android lifecycleKotlin basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The solution involves moving the update triggering code from onPause() to onDestroy() in MainActivity. A persistent notification with an 'Update now' action should be added. Start by examining the current update logic in MainActivity's onPause() method (likely in the cloudstream Android app). Then migrate that logic to onDestroy() and create a notification using Android's NotificationManager. Ensure that the notification includes a PendingIntent to trigger the update when clicked. Also consider the behavior for PiP (picture in picture) mode to avoid triggering the update inadvertently.