readthedocs/sphinx_rtd_theme

Duplicated access key of the prev and next buttons when prev_next_buttons_location == 'both'

Open

#1,057 创建于 2021年2月23日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)CSS (3,473 star) (1,413 fork)batch import
AcceptedBugGood First Issue

描述

Problem

The Chrome Lighthouse auditor report some accessibility problems; _ Color contrast problems in the lateral nav bar _ Missing aria-label in the input search box _ Duplicated access key of the previous and next buttons when variable theme_prev_next_buttons_location == 'both'

Reproducible Project

The first two are available in all rtd doc like: https://sphinx-rtd-theme.readthedocs.io/en/latest/ The third one need variable theme_prev_next_buttons_location == 'both'

Expected Results

Improve Chrome Lighthouse audit score

贡献者指南

技术栈
htmlcss
领域
accessibilitydocumentation
议题类型
accessibility
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
HTML accessibilitySphinx theme structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the template files that render the prev/next navigation buttons, likely in the theme's layout.html or a partial template. Look for the access key attribute duplication when `theme prev next buttons location` is set to 'both'. Check for any existing PRs or comments. Consider adding unique access keys by location or removing duplicate.