reactstrap/reactstrap

Should we add size check to tests

Open

#475 创建于 2017年6月23日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (10,557 star) (1,347 fork)batch import
PR Welcomehelp wantedup-for-grabs

描述

4.6.0 introduced an issue with the bundle size that went unnoticed. As a comment on PR #474 which fixes the size issue, @nathancahill suggested we make bundle size part of the build process.

Instead of the build process, I think we should add it as a test. That way when a PR breaks the build, CI will fail. If it's part of the build process, we will only notice something is broken when we try to do a release and have to hunt down which PR broke it.

It would require us to do a prod build before running the tests. This currently takes ~13s on my machine.

Initially I would suggest we set the limit to 150kB. That's ~50% above the current size. This should catch increases introduced by both #399 and #433.

This wouldn't be a hard limit either. We just need some number to catch big increases.

贡献者指南

技术栈
javascriptreact
领域
testing
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.jsnpmReact basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Review the repo's package.json for build scripts and existing test setup. The issue suggests adding a test that fails if the production bundle exceeds 150kB. Look into using a library like 'bundlesize' or 'size limit', and ensure the test runs after a production build. Check PR #474 for context on the bundle size fix.