reactorlabs/rir

support for named indices

开放

#798 创建于 2020年1月24日

 (0 条评论) (0 个反应) (0 位负责人)C++ (19 个派生)github user discovery
enhancementhelp wanted

仓库指标

星标
 (61 个星标)
PR 合并指标
 (平均合并 1分钟) (30 天内合并 1 个 PR)

描述

The description here depends on some type inference inprovements in #797

Reproduce

run with PIR_DEBUG=PrintPirAfterOpt

f <- function() {
  a <- c(1,2,3)
  names(a) <- c("one", "two", "three")
  a['one'] + a['two']
}
f()
f()
f()

Observe that the result contains:

  str$"           %2.4  = LdConst                  [1] "one" 
  real$'<real'>   %2.5  = Extract1_1D        wed   %2.3, %2.4, elided

there are two issues here:

  1. the index of "one" is computed at runtime
  2. the result is tagged, because it has an attribute (ie. a name)

Resolving issue (2) is probably a longterm goal, that needs many changes. but (1) should be approachable.

Possible Solution

Currently our type feedback records if a value has attributes (except dimension attrs of matrix) here. We could extend this to specifically record the names attribute.

If the names attribute is stable, we could speculate on it and compute the index at compile time.

贡献者指南