reactjs/react-modal

Pressing enter key to close button closes the modal but the event is attached to opener element and reopens the modal

Open

#954 创建于 2022年6月18日

在 GitHub 查看
 (12 评论) (0 反应) (0 负责人)JavaScript (7,294 star) (828 fork)batch import
discussioneventshelp wantedmaybe bugneeds info

描述

Summary:

Steps to reproduce:

  1. Visit my demo on Codesandbox https://codesandbox.io/s/react-modal-vivyxc?file=/src/index.js
  2. Click 'Open Modal' button and press Tab. This will focus the close button
  3. Press Enter this closes the modal but reopens it. I know this is because of the onKeyUp event listener to anchor tag but this function is needed for other purposes.

Expected behavior:

Closes modal and focus move to the opener element( in this case, anchor tag)

Link to example of issue:

Codesandbox https://codesandbox.io/s/react-modal-vivyxc?file=/src/index.js

Additional notes:

Is there a way to solve this issue without removing the onKeyUp event handler?

Thanks.

贡献者指南

技术栈
javascriptreact
领域
frontendaccessibility
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic React knowledgeUnderstanding of event propagation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Start by examining the provided CodeSandbox (https://codesandbox.io/s/react modal vivyxc) to understand the current modal component structure. Focus on the onKeyUp event handler attached to the anchor tag (opener element) and how it interacts with the modal close button. Investigate whether adding event.stopPropagation() or checking the event target in the handler can prevent the modal from reopening after closing. Also review the modal's focus management logic to ensure focus returns to the opener element correctly. Look for any existing comments or maintainer suggestions in the issue thread.