reactjs/react-modal

Focus escapes modal when radio buttons in modal

Open

#636 创建于 2018年3月29日

在 GitHub 查看
 (8 评论) (11 反应) (0 负责人)JavaScript (7,294 star) (828 fork)batch import
accessibilitybugeasygood first issue

描述

Summary:

When there are radio buttons in a modal, you can escape focus with shift-tab.

Steps to reproduce:

Steps are included in the test case below

Expected behavior:

You should not be able to escape the modal's focus

Link to example of issue:

https://codesandbox.io/s/my9vm34m68

Additional notes:

Not sure if it's related specifically to radio buttons, but that is what is causing the issue for me

贡献者指南

技术栈
reactjavascript
领域
frontendaccessibility
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React basicsFocus management in web appsUnderstanding of tab order
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the focus trapping logic in the modal component, likely in files like 'src/components/Modal.js' or similar. The provided CodeSandbox (https://codesandbox.io/s/my9vm34m68) demonstrates the issue with Shift+Tab escaping when radio buttons are present. Review the focus management code, particularly how it handles the first and last focusable elements, and ensure radio buttons are properly included in the focus order. Consider using a focus trap library like 'focus trap' or adjusting the existing implementation to handle the radio button's group focus behavior.
Focus escapes modal when radio buttons in modal · reactjs/react-modal#636 | Good First Issue