reactjs/react-modal

Focus escapes modal when the last element in the modal is an iframe

Open

#226 创建于 2016年9月19日

在 GitHub 查看
 (2 评论) (2 反应) (0 负责人)JavaScript (7,294 star) (828 fork)batch import
bughelp wanted

描述

Summary:

When an iframe is the last element in the modal, focus escapes the modal when using keyboard navigation. This is problematic particularly for screen reader users since the rest of the DOM has aria-hidden set to true. Screen readers are no longer able to access the modal once focus has escaped from it. I used Chrome Version 53.0.2785.116 (64-bit).

Steps to reproduce:

  1. Unzip the modal-test.zip file
  2. Run npm install
  3. Run npm run build
  4. Run node index.js
  5. Navigate to page and tab through until focus escapes the modal (wikipedia has a lot of links so tabbing takes awhile)

Expected behavior:

Focus should be contained within the modal even if an iframe is the last element in the modal.

modal-test.zip

贡献者指南

技术栈
reactjavascripthtmlcss
领域
accessibilityfrontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactFocus managementAccessibility basicsNode.js/npm
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the focus trapping mechanism in the React Modal component, particularly the logic that manages keyboard navigation within the modal. Look at the source files under the src/ directory for functions handling focus and iframe elements. Consider testing with the provided test case to reproduce the issue. There may be existing discussions or references in the repository's issues or pull requests that offer insights.