reactjs/react-modal

Add support for React & Node 18 (as easy as adding startTransition() on each setState)

Open

#1,019 创建于 2023年5月8日

在 GitHub 查看
 (19 评论) (0 反应) (0 负责人)JavaScript (7,294 star) (828 fork)batch import
easygood first issue

描述

Summary:

Current react modal doesn't work with latest version of React + Node v18

Steps to reproduce:

  1. Use react-modal with latest React's and Node v18

Expected behavior:

Should work normally

Example of issue:

Breaks with the following error message:

Solution:

Simply add startTransition() wrapping each of the calls for setting the state. startTransition(() => setState("something))

贡献者指南

技术栈
javascriptreact
领域
frontendaccessibility
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React fundamentalsstartTransition APIreact modal codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The issue requires adding startTransition() to each setState call in the react modal component. First, identify all state updates in the source code, likely in the main modal component file. Then, wrap each setState with startTransition to make it compatible with React 18. Ensure no breaking changes and test with the latest React version.