reactjs/react-modal

Replace focus trap with `inert`

Open

#1,011 创建于 2023年3月29日

在 GitHub 查看
 (1 评论) (4 反应) (0 负责人)JavaScript (7,294 star) (828 fork)batch import
accessibilitybrowser apicombining librariesdependenciesdiscussioneasyfeaturegood first issue

描述

Now that browsers have good support for inert, could we consider replacing the custom focus trap logic with this?

Alternatively, we could use the dialog element so we get this behaviour for free.

贡献者指南

技术栈
reactjavascript
领域
accessibilityfrontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React component structurefocus trap conceptHTML inert attribute
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Investigate the current focus trap implementation in react modal (likely in src/modal.js or similar). Determine whether the `inert` attribute can be applied to the modal's backdrop or content. Consider the two approaches: adding `inert` to siblings or using the native `<dialog>` element. Check browser support and fallback for older browsers. Review the existing comment for maintainer feedback.