react/create-react-app

Allow JSON with comments in jsconfig.json

Open

#7,426 创建于 2019年7月25日

在 GitHub 查看
 (15 评论) (0 反应) (0 负责人)JavaScript (103,386 star) (27,059 fork)batch import
contributions: claimeddifficulty: mediumgood first issueissue: proposal

描述

Is your proposal related to a problem?

This is a follow-on from #7248. Right now, we don't support JSONC (JSON with comments) in jsconfig.json files.

Describe the solution you'd like

After a discussion with @iansu, we see two paths:

  1. Implement the same solution as we did for TypeScript. This is easy, but would require us making TypeScript a dependency of react-scripts.
  2. The above, but instead of installing typescript as a dependency of react-scripts, we would install it to the user's project if they are using a jsconfig.json file and don't have typescript installed.

Discussion is welcome.

If you're interested in picking this up, please let us know.

贡献者指南

技术栈
javascripttypescript
领域
frontendtoolingbuild system
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with JSONCUnderstanding of jsconfig.jsonKnowledge of React scriptsBasic understanding of TypeScript dependency
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Read the linked issue #7248 to understand previous discussions. Evaluate the two proposed solutions: implementing TypeScript support as done for TypeScript (requires making TypeScript a dependency) or installing TypeScript only for jsconfig users without it. Check if the community has expressed a preference. Look at the current codebase to see how tsconfig.json is handled for TypeScript projects. The issue lacks a final decision, so the contributor should propose a clear plan or seek maintainer input.
Allow JSON with comments in jsconfig.json · react/create-react-app#7426 | Good First Issue