react-native-elements/react-native-elements

Add accessibilityHint and accessibilityLabel support to ButtonGroup buttons

Open

#3,196 创建于 2021年9月4日

在 GitHub 查看
 (9 评论) (3 反应) (0 负责人)TypeScript (23,818 star) (4,564 fork)batch import
Good First Issueaccessibilitycomponent: ButtonGroup

描述

Is your feature request related to a problem? Please Describe.

Add accessibilityHint and accessibilityLabel support to ButtonGroup buttons. Currently when I try to pass in a custom button component like this to the ButtonGroup buttons prop:

const buttons = [
  (
    <Text
      accessibilityHint={translate('ARIA HINT - Tap to search by podcast title')}
      accessibilityLabel={translate('Search by podcast title')}>
      {translate('Podcast')}
    </Text>
  ),
  (
    <Text
      accessibilityHint={translate('ARIA HINT - Tap to search by podcast host')}
      accessibilityLabel={translate('Search by podcast title')}>
      {translate('Host')}
    </Text>
  )
]

Neither the accessibilityHint or accessibilityLabel are read. I think it may be because the ButtonGroup buttons are wrapped in their own that we cannot override or configure with props.

Describe the solution you'd like

When accessibilityHint and accessibilityLabel are provided for custom ButtonGroup buttons, they should be read by iOS and Android screen readers. This solution may require optionally overriding the wrapping the ButtonGroup buttons.

Describe alternatives you've considered

I can't think of another way to accomplish the same thing.

贡献者指南

技术栈
react nativetypescript
领域
mobileaccessibility
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with React Native accessibilityUnderstanding of ButtonGroup component structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Start by examining the ButtonGroup component source code, likely in src/buttons/ButtonGroup.js or similar. Identify where the wrapping Touchable is used and how custom button components are rendered. Look for existing patterns of passing accessibility props to Touchable in other components (e.g., Button). The goal is to add optional accessibilityHint and accessibilityLabel props to ButtonGroup, and propagate them to the internal Touchable for each button. Check if there are any existing PRs or discussions about this (issue #3196 is the only one). Consider adding a 'buttonAccessibilityProps' prop or directly supporting accessibilityHint/accessibilityLabel on each button config object.