react-bootstrap-table/react-bootstrap-table2

Add callback when editing on cell is cancelled

Open

#684 创建于 2018年11月26日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (1,249 star) (415 fork)batch import
cell-editorgood first issuehelp wanted

描述

In version 1.2.2 of react-bootstrap-table2-editor, it is possible to be notified when a cell enters the editing state using onStartEdit. However, if blurToSave is set to false, there is no way to determine that editing was cancelled when the user clicks away from the editing cell and the cell transitions back to a non-editing state. It would be very useful to have a onEditCancel (or some other appropriate name) callback method that could be set for this case. When blurToSave is true, all is fine as any change in focus, leads to the afterCellSave method to be called.

贡献者指南

技术栈
reactjavascript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Reactreact bootstrap table2 basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Examine the current implementation of cell editing in the package, specifically the onStartEdit callback and how the cell transitions between editing and non editing states when blurToSave is false. Look at the source code for the cell editor component to understand where to hook in a new onEditCancel prop. Consider how to differentiate between save and cancel events, and ensure the new callback is only triggered on cancellation. Check existing tests for similar callbacks to follow the pattern.