rapidsai/cudf

Add unit tests for fixed point in quantiles

Open

#9,469 创建于 2021年10月19日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)C++ (6,000 star) (735 fork)batch import
buggood first issuelibcudftests

描述

Describe the bug Quantiles support fixed point columns. but it is not tested in unit tests (both gtest and pytest).

Expected behavior add unit tests for fixed_point in quantiles gtest

Additional context https://github.com/rapidsai/cudf/issues/9468 While adding FixedPointTypes to cudf::test::AllTypes, QUANTILES_TEST (Failed).

[ FAILED ] QuantileUnsupportedTypesTest/10.TestZeroElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/10.TestOneElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/10.TestMultipleElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestZeroElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestOneElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10> [ FAILED ] QuantileUnsupportedTypesTest/11.TestMultipleElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10>

6 FAILED TESTS

贡献者指南

技术栈
cpppython
领域
testingdata
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++CUDAcudfgtest
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Review the quantile test file (likely in cpp/tests/quantile/ or similar) and the existing test suite. Refer to issue #9468 for context on FixedPointTypes. Add FixedPointTypes to the AllTypes list in the quantile test and ensure the tests pass. Investigate the cause of the failures for fixed point with int and long underlying types.