rapidsai/cudf

[FEA] Explicitly guarantee row group ordering in the parquet reader.

Open

#15,697 创建于 2024年5月7日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C++ (6,000 star) (735 fork)batch import
cuIOfeature requestgood first issueimprovementlibcudf

描述

From @devavret , the question came up as to whether we guarantee the relative ordering of row groups across multiple input files in the parquet reader. That is, if you have two files [f1, f2] and the row groups within the files (in one column) are specified as [[r0,r3], [r0,r1]], do we guarantee the output ordering would be [f1r0, f1r3, f2r0, f2r1]

The code does in fact do this for both the explicitly specified case and the unspecified (empty user input / all row groups), but we don't make any guarantees about it. Seems like a safe and easy thing to add.

https://github.com/rapidsai/cudf/blob/5d244dfc13f4db0b1e41ded3029942fec50c98f6/cpp/src/io/parquet/reader_impl_helpers.cpp#L663

贡献者指南

技术栈
cpp
领域
data
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of parquet file formatFamiliarity with C++
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Examine the code at cpp/src/io/parquet/reader impl helpers.cpp line 663 where row group ordering is currently implicit. The goal is to explicitly guarantee the ordering of row groups across multiple input files. This likely involves adding a comment or documentation in the header or API, ensuring that the existing behavior is contractually guaranteed. Look for any existing tests for row group ordering and consider adding a test to enforce the guarantee.
[FEA] Explicitly guarantee row group ordering in the parquet reader. · rapidsai/cudf#15697 | Good First Issue