rapidsai/cudf

[FEA] Change cudf::io::detail::make_column() to have a more verbose name.

Open

#11,391 创建于 2022年7月28日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C++ (735 fork)batch import
cuIOgood first issueimprovementlibcudfproposal

仓库指标

Star
 (6,000 star)
PR 合并指标
 (平均合并 17天 21小时) (30 天内合并 230 个 PR)

描述

std::unique_ptr<column> make_column(column_buffer& buffer,
                                    column_name_info* schema_info,
                                    rmm::cuda_stream_view stream,
                                    rmm::mr::device_memory_resource* mr)

This is kind of a weakly named global function. Because its name is so generic, it doesn't play nice with users who might want to create their own, more appropriately named make_column that does some other work along the way. Changing this to column_from_column_buffer() or make_column_from_buffer(), or maybe making it a member of column_buffer would clean things up a bit

Eg.

// user function (in parquet code for example)
make_column(column_buffer &b)
{
    // random preprocessing work
    auto x = column_from_column_buffer(b);
    // random postprocessing work
}

贡献者指南