quickwit-oss/tantivy

Generate meaningful SegmentIDs instead of pure random

Open

#971 创建于 2021年1月7日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Rust (8,354 star) (499 fork)batch import
enhancementgood first issuehigh priorityquickwit

描述

Is your feature request related to a problem? Please describe. Related to #969 I would like to suggest a cheap feature which will help debugging in the future. Now SegmentIDs are generated randomly but it is a waste of 16 bytes which could be used to embed debugging info otherwise.

Describe the solution you'd like Generate SegmentID containing the following info:

  • timestamp of segment creation
  • segment origin (merging or writing new data)
  • hash of hostname, probably useful for those who will implement sharding/replication paired with Tantivy.

Additionally here we should ensure that there is left enough randomness to avoid any possibility of collisions on the one hand, and that names are not too long to avoid metadata bloating (? not sure if it is actual, the number of segments is supposed to be relatively low by design afaik) on the other hand.

贡献者指南

技术栈
rust
领域
backenddatabase
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
RustTantivy basicsSegment concept
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
The SegmentID generation logic is likely in the segment module (e.g., segment id.rs). Examine the current random generation and design a new struct that embeds a timestamp, origin flag, and a hash of the hostname while retaining enough randomness. Check issue #969 and the comments in this issue for additional context on requirements.