qmk/qmk_firmware

[Bug] NOOP keys kill combos

Open

#19,446 创建于 2022年12月30日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)C (43,867 fork)batch import
bughelp wanted

仓库指标

Star
 (20,368 star)
PR 合并指标
 (平均合并 20天 9小时) (30 天内合并 27 个 PR)

描述

Describe the Bug

The issue is that whenever a NOOP key is pressed down along with a valid combo, the combo doesn't fire.

Use case:

I am using an ortholinear split keyboard with left shift + right shift combo as caps lock toggle. The right shift is 2U with a POS keycap so the underlaying switches are KC_RSFT and XXXXXXX (using the right switch as a stabilizer because the pcb doesn't support 2U key in that position).

Expected behavior:

NOOP shouldn't interfere with combos because by definition the key should be ignored.

Notes:

I tried the combo with 1U keycaps (meaning the NOOP key is not pressed) and it works fine, so the problem is indeed the NOOP interfering with combos.

Keyboard Used

keebio/viterbi/rev2

Link to product page (if applicable)

https://keeb.io/products/viterbi-keyboard-pcbs-5x7-70-split-ortholinear

Operating System

Microsoft Windows 11

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

贡献者指南