pytorch/ignite

`Timer`'s misleading behaviour when epoch completion time calculated

Open

#2,157 创建于 2021年8月11日

在 GitHub 查看
 (7 评论) (1 反应) (1 负责人)Python (4,313 star) (602 fork)batch import
HacktoberfestPyDataGlobalenhancementhelp wanted

描述

When I tried calculating the time taken to complete a single epoch via Timer, the handlers attached to trainer before Timer were executed first, and thus their time also got recorded by the Timer too for a single epoch. Therefore the true time taken for epoch completion, provided by trainer.state.times, is less than what Timer calculated. This can be misleading. More clarification on how this actually works in the docs would be appreciated. Or the Timer's functionality can be enhanced to step before all other handlers attached to an event could also be helpful. Notebook to quickly verify this here.

贡献者指南

技术栈
pythonpytorch
领域
machine learningdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with PyTorch Ignite event system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the Timer implementation in PyTorch Ignite, specifically how it hooks into events. The issue suggests that Timer should step before other handlers. Check the source code for the Timer class and its event registration. Consider whether a simple reordering of handler execution or a new event attribute is needed. The provided Colab notebook can be used to reproduce the issue.