pytorch/examples

imagenet benchmark measure elapsed time function issue

Open

#741 创建于 2020年3月23日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Python (21,634 star) (9,429 fork)batch import
good first issue

描述

Hi Pytorch team, I think the measure elaspsed time function is not right. Both trainning and validate function show the progress if i %args.print_freq == 0 in magenet/main.py . currently, the batch_time only measure one loop. I think the batch_time should measure args.print_freq loop elaspsed time.

     # measure elapsed time
     batch_time.update(time.time() - end)
     end = time.time()

     if i % args.print_freq == 0:
         progress.display(i)

贡献者指南

技术栈
python
领域
machine learning
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic PythonPyTorch basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The issue is in imagenet/main.py. Currently, batch time.update is called every iteration, but it should average over args.print freq iterations. The fix involves moving the measurement to after the print freq loop or accumulating time over multiple iterations. Examine lines around batch time.update and the loop condition to implement the change.