pytorch/examples

Ambiguous code in reinforce

Open

#297 创建于 2018年2月2日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Python (21,634 star) (9,429 fork)batch import
good first issue

描述

In /reinforcement_learning/reinforce.py, line 91:

running_reward = running_reward * 0.99 + t * 0.01

The variable running_reward seems to used for record average episodic rewards(not actually average, but I think the concept is similar), 0.01, is the scalar to update the average episodic rewards and t is done step. Add some comment or refactor naming may help beginners to understand this example.

贡献者指南

技术栈
python
领域
documentationmachine learning
议题类型
documentation
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic Pythonreinforcement learning basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
The issue points to line 91 in `/reinforcement learning/reinforce.py`. The variable `running reward` and the update formula `running reward * 0.99 + t * 0.01` are confusing. A comment explaining that this computes an exponential moving average of episode rewards, or renaming `running reward` to something like `avg reward`, would clarify the code. Check the file for existing comments and coding style. No linked pull requests or maintainer responses are present. Ensure the change is consistent with other examples in the repository.