pytorch/examples

storing the best model

Open

#232 创建于 2017年10月12日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Python (21,634 star) (9,429 fork)batch import
good first issue

描述

https://github.com/pytorch/examples/blob/7d0d413425e2ee64fcd0e0de1b11c5cca1f79f4d/word_language_model/main.py#L171 doesn't look like it is actually saving the best model? It saves only the current model

贡献者指南

技术栈
python
领域
machine learning
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PythonPyTorch basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The issue points to line 171 in word language model/main.py (https://github.com/pytorch/examples/blob/7d0d413425e2ee64fcd0e0de1b11c5cca1f79f4d/word language model/main.py#L171). The current code saves the model at the end of each epoch, but the issue states it saves the current model, not the best one. To fix, add logic to track the best validation loss and save the model only when a new best is achieved. Ensure the model state is properly saved using torch.save. The change should be localized to the training loop around that line. No linked PRs or recent comments indicate active work.