pyro-ppl/pyro

Incorrect stack terminology in Poutine and minipyro.py

Open

#3,088 创建于 2022年5月13日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Python (981 fork)batch import
documentationhelp wanted

仓库指标

Star
 (8,211 star)
PR 合并指标
 (平均合并 10天 19小时) (30 天内合并 1 个 PR)

描述

The Poutine example page and the minipyro.py example script flip the standard terminology of the stack data structure. One adds and removes from the top of the stack, but in these pages this is flipped. As pedagogical resources, this inverted terminology adds unnecessary confusion.

For example, when iterating over the stack in minipyro.py:

PYRO_STACK is reversed so that effect handlers higher in the stack are first applied.

and in http://pyro.ai/examples/effect_handlers.html#Interlude:-the-global-Messenger-stack:

Messenger.__enter__ appends a Messenger to the end (the bottom) of the global handler stack

贡献者指南