pymc-devs/pymc

CheckParameterValues not replaced in inner graphs

Open

#6,697 创建于 2023年4月28日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Python (7,926 star) (1,902 fork)batch import
help wantedlogprob

描述

We include these rewrites when compiling logp graphs, but this won't replace inner logp graphs (e.g, inside Scan or not-inlined OpFromGraph)

https://github.com/pymc-devs/pymc/blob/371472dcf1c44f99a9ad4e7317606404b2a47a0e/pymc/pytensorf.py#L1142-L1144

The example in #6696 suffers from this. Sampling is quite faster when the rewrite is manually added

贡献者指南

技术栈
python
领域
backendperformance
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of PyMC compilation pipelineFamiliarity with graph rewrites in PyTensor
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue is that the CheckParameterValues rewrite is not applied to inner graphs (e.g., inside Scan or not inlined OpFromGraph). The relevant code is at pymc/pytensorf.py lines 1142-1144. The fix would involve ensuring this rewrite is recursively applied to all subgraphs. Start by examining how rewrites are applied in the compilation process, and look at the example in issue #6696 to reproduce the performance difference. Consider modifying the rewrite application logic to traverse inner graphs.
CheckParameterValues not replaced in inner graphs · pymc-devs/pymc#6697 | Good First Issue