pyjanitor-devs/pyjanitor

[ENH] add_column fix

Open

#408 创建于 2019年7月13日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Python (164 fork)batch import
enhancementgood first issuegood intermediate issue

仓库指标

Star
 (1,217 star)
PR 合并指标
 (平均合并 2天 12小时) (30 天内合并 4 个 PR)

描述

Currently, the add_column function contains the parameter fill_remaining. I believe this parameter could be combined with the value parameter, such that when a list or tuple is inputted into value, it should automatically repeat to fill up the remainder of the column rather than having to specify that in another parameter (fill_remaining). (Also, whenever a list/tuple of a different size from the number of rows is inputted anyway, there is an error. So in my opinion, it would be more efficient to just automatically have the list/tuple iterate until it fills up the remainder of the column solely through inputting the list/tuple into the values parameter rather than also having the fill_remaining parameter.)

is also due to inputting a tuple/list of a different size than the column size will lead to an error anyway)

Relevant Context

贡献者指南