py-why/dowhy

effect_modifiers

Open

#767 创建于 2022年11月18日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Python (6,453 star) (883 fork)batch import
buggood first issue

描述

Describe the bug I'm trying to estimate the causal effect by calling the "econml" package and specified an "effect_modifiers" variables that is continuous value ,but also I want set the parameters "num_quantiles_to_discretize_cont_cols = 6"

Steps to reproduce the behavior

dml_estimate = model.estimate_effect(identified_estimand, method_name="backdoor.econml.dml.DML",
                                     control_value = 0,
                                     treatment_value = 1000,
                                     effect_modifiers=['solar_radiation'],
                                 target_units = 'ate',#lambda df: df["diffusion_conditions"]==1,  # condition used for CATE
                                 confidence_intervals=False,
                                     num_quantiles_to_discretize_cont_cols = 6,
                                method_params={"init_params":{
                                                              'model_y':GradientBoostingRegressor(),
                                                              'model_t': GradientBoostingRegressor(),
                                                              "model_final": LassoCV(fit_intercept=False),
                                                              'featurizer':PolynomialFeatures(degree=1, include_bias=True)
                                                              },
                                                "fit_params":{
                                                    'inference':BootstrapInference(n_bootstrap_samples=100, n_jobs=-1),}
                                               })

TypeError Traceback (most recent call last) ~\AppData\Local\Temp\ipykernel_3380\140799330.py in 25 }, 26 "fit_params":{ ---> 27 'inference':BootstrapInference(n_bootstrap_samples=100, n_jobs=-1),} 28 }) 29 print(dml_estimate)

TypeError: estimate_effect() got an unexpected keyword argument 'num_quantiles_to_discretize_cont_cols'

Expected behavior I really expected i would have report behavior like below: image

Version information:

  • DoWhy version [e.g. 0.7]

Additional context Add any other context about the problem here.

贡献者指南

技术栈
python
领域
datamachine learning
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic Pythonfamiliarity with DoWhy API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the `estimate effect` method signature in the DoWhy source code (likely in `dowhy/causal estimator.py`) to confirm that `num quantiles to discretize cont cols` is not a valid argument. Check if this parameter belongs to another method like `CausalModel` or should be passed via `method params`. Review the documentation and existing tests for correct usage. Consider opening a PR to either add support for this parameter in `estimate effect` or clarify the error message to guide users to the correct parameter placement.