psf/requests-html

When requesting a page that is ISO-8859-1 encoded, HTML is still interpreted as UTF-8

Open

#442 创建于 2021年1月27日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Python (13,555 star) (976 fork)batch import
help wanted

描述

When requesting a page that is ISO-8859-1 encoded:

>>> r = session.get('https://gerda.geus.dk/Gerda/Search')
>>> r.encoding
'ISO-8859-1'
>>> r.html.default_encoding
'ISO-8859-1'
>>> r.html.encoding
'utf8'
>>> r.html.find("option")[-1].text
'Bygge-anl�g'

Expected behavior:

>>> r.html.find("option")[-1].text
'Bygge-anlæg'

As far as I can see, there are two problems:

  • r.html.encoding is incorrectly set
  • r.html.element (The PyQuery instance) does not take encoding into account at all but just assumes utf-8

贡献者指南

技术栈
pythonhtml
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Python basicsHTML parsingCharacter encoding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The issue identifies two specific problems: `r.html.encoding` is incorrectly set, and the `PyQuery` instance doesn't consider encoding. Start by examining the `requests html.py` file to understand how `encoding` and `default encoding` attributes are handled. Look at the `HTML` class constructor and how it initializes PyQuery. Consider modifying the encoding detection to use the response's apparent encoding, and ensure PyQuery receives the correct encoding. Check if there are any tests in the test suite related to encoding to guide the fix.