provectus/kafka-ui

[Topics] Retention bytes custom parameter overrides the "Max size on disk in GB" value within Topic

Open

#3,270 创建于 2023年1月26日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Java (7,799 star) (977 fork)batch import
good first issuescope/frontendstatus/acceptedtype/bug

描述

Describe the bug (Actual behavior) When user is selecting "Max size on disk in GB" value (10 GB) and then add the Custom parameter "Retention bytes" with any value, after saving and editing the Topic, added custom parameter keeps and "Max size on disk in GB" value returns to "Not Set"

Expected behavior

  • If the "Max size on disk in GB" is selected, "Retention bytes" can be removed from Custom parameter dropdown values
  • If user lets "Max size on disk in GB" to be "Not set" or select any value (1, 10, 20, 50 GB) and then add the Retention bytes, after Topic save, the value of custom retention bytes can be displayed in "Max size on disk in GB" instead of "Not set"
  • Suggested to change "Max size on disk in GB" to be "Max size on disk "

Set up https://www.kafka-ui.provectus.io/

Steps to Reproduce

  1. Navigate to Topics
  2. Add required data
  3. Select "10 GB" for " "Max size on disk in GB"
  4. Add custom parameter
  5. Select retention bytes
  6. Fill value
  7. Save the Topic
  8. Press "Edit settings" from 3dot menu

Screenshots

https://user-images.githubusercontent.com/104780608/214736529-8e872422-685b-4eb4-92fe-09d74d64d03c.mov

Additional context relates to https://github.com/provectus/kafka-ui/issues/3071

贡献者指南

技术栈
javareacttypescript
领域
frontendbackend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of Kafka topic configurationFamiliarity with React state management
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the topic creation/edit form component in the frontend (likely located in the kafka ui/src/.../Topics/ directory). Identify how 'Max size on disk in GB' and custom parameter 'retention bytes' are stored and synchronized. Check for existing logic that handles the override behavior and consider implementing the expected behavior: either remove 'retention bytes' from custom parameters when 'Max size on disk' is set, or update the 'Max size on disk' field to reflect the custom retention bytes value. Review related issue #3071 for context. The fix should be localized to the topic form component and its state management.
[Topics] Retention bytes custom parameter overrides the "Max size on disk in GB" value within Topic · provectus/kafka-ui#3270 | Good First Issue