protocolbuffers/protobuf

Include valid proguard config in java protolite library

Open

#11,252 创建于 2022年12月12日

在 GitHub 查看
 (2 评论) (0 反应) (1 负责人)C++ (16,128 fork)batch import
help wantedjava

仓库指标

Star
 (71,223 star)
PR 合并指标
 (平均合并 2天 11小时) (30 天内合并 185 个 PR)

描述

Related to

https://issuetracker.google.com/issues/144631039 and https://github.com/protocolbuffers/protobuf/issues/6463

What language does this apply to?

Java Protolite

Describe the problem you are trying to solve.

Include necessary proguard definitions to avoid failures in release builds.

Describe the solution you'd like

Include https://github.com/protocolbuffers/protobuf/blob/520c601c99012101c816b6ccc89e8d6fc28fdbb8/java/lite/proguard.pgcfg in the library, so it's applied automatically.

See https://github.com/square/okhttp/blob/master/docs/features/r8_proguard.md for how this feature works in other libraries

https://raw.githubusercontent.com/square/okhttp/master/okhttp/src/jvmMain/resources/META-INF/proguard/okhttp3.pro

Describe alternatives you've considered

Currently every app needs to fail initially, search for the error message and include the same fix.

贡献者指南