project-chip/connectedhomeip

Reduce/remove usage of "all ids/structs/enums" and include exact cluster dependencies

Open

#38,667 创建于 2025年4月29日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)C++ (6,410 star) (1,659 fork)batch import
good first issuestale

描述

We have split cluster specific data into separate files, however we still have usages of global things assumed within various locations. part of it is src/app/clusters which may need treating one by one, however others are the rest of the SDK code.

We should replace https://github.com/project-chip/connectedhomeip/blob/master/zzz_generated/app-common/app-common/zap-generated/cluster-objects.h usage and https://github.com/project-chip/connectedhomeip/blob/master/zzz_generated/app-common/app-common/zap-generated/cluster-enums.h usage with actual cluster/.../....h includes instead

and ensure references for ids include the correct header.

Practical example, WriteClient needs AccessControl::Id https://github.com/project-chip/connectedhomeip/blob/master/src/app/WriteClient.cpp#L273 and it should not assume that this is somehow available through transitive dependencies (it seems to do that now).

Need to figure out how to audit usages of these IDs and clean up references.

贡献者指南

技术栈
cpp
领域
tooling
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
over 1 week
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
C++Matter project structureinclude dependenciescode organization
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
Audit the codebase for includes of cluster objects.h and cluster enums.h in all .cpp and .h files. For each file, identify which cluster IDs or structs are used, and include the corresponding cluster specific header instead. Start with the example in WriteClient.cpp where AccessControl::Id is used via transitive dependency, and replace the global include with <AccessControl.h>. Then expand to other files using similar pattern. Use grep or a script to find all usages of global generated headers and ensure all cluster dependencies are explicit.