pass query parameters through to metamodel syntax · probcomp/bayeslite#446

(0 评论) (0 反应) (0 负责人)Python (915 star) (63 fork)batch import

help wantedk days

描述

Currently we do not distinguish

CREATE GENERATOR g FOR p USING m ("foo")

from

CREATE GENERATOR g FOR p USING m ('foo')

which is not at the moment blocking anything (hence the stall of #410), but which may be worth fixing soon. Furthermore, passing a verbatim string through, e.g. to provide the source code in

CREATE GENERATOR g FOR p USING cgpm (
    MODEL x GIVEN y USING venturescript (source = 'assume x = 42; ...')
)

as we kludgily do in https://github.com/probcomp/bayeslite/blob/f3f27a584286a4f3f3a415a7935da6ea78bd9824/tests/test_vscgpm.py#L166-L179 with Python string formatting, is not easy to do reliably. That fragment just assumes no " appears in the VentureScript code, and abuses "..." quotation, which in SQL means names, with '...' meaning strings. No quotation should be necessary on the user's part -- it should be possible to do

bdb.execute('CREATE GENERATOR ... USING venturescript (source = ?) ...', (venturescript,))

and get the same intended effect reliably.

贡献者指南

技术栈: pythonsql
领域: database
议题类型: feature
难度: 3
预计时间: 1-3 hours
活动状态: stale
清晰度: mostly clear
前置要求: PythonSQLBayeslite internals
新手友好度: 30
研究方向: Look into the parsing of CREATE GENERATOR statements in Bayeslite. The issue mentions issue #410 which might have related discussion. The test file tests/test vscgpm.py shows a workaround. The goal is to distinguish between double quoted and single quoted strings and properly handle parameterized queries. Suggested approach: modify the parser to differentiate SQL string literals from identifiers when passing arguments to metamodel syntax.