probcomp/bayeslite

latent variables cannot be inputs to CGPM foreign models

Open

#445 创建于 2016年7月12日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Python (63 fork)batch import
help wantedk min/hr

仓库指标

Star
 (915 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

create generator g for p using cgpm (
    model foo given err using venturescript (sp = errfoo),
    latent err numerical
)

This will not work because cgpm_metamodel._create_schema assumes that every input to a foreign model exists as a manifest variable of the population, and passes them to core.bayesdb_variable_stattype to determine the statistical type.

The logic in _create_schema must be changed to defer whatever processing requires the statistical types of inputs to foreign models until after all clauses have been ingested, and then update that processing to use latents (the mapping from latent variable names to their respective statistical types) instead of core.bayesdb_variable_stattype when appropriate.

贡献者指南