prestodb/presto

ST_Centroid (Java) does not comply with ISO spec

Open

#26,947 创建于 2026年1月12日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Java (15,558 star) (5,240 fork)batch import
buggood first issue

描述

In the ISO spec, ST_Centroid(empty_geometry) returns NULL, but in the Java code it returns an empty geometry. This is fixed for Velox/native in https://github.com/facebookincubator/velox/pull/15985 , but should also be fixed in Java.

Expected Behavior

ST_Centroid(ST_GeometryFromText('LINESTRING EMPTY')) IS NULL

Current Behavior

ST_IsEmpty(ST_Centroid(ST_GeometryFromText('LINESTRING EMPTY')))

Possible Solution

The ST_Centroid function should check for an empty input geometry and return null.

Steps to Reproduce

SELECT ST_Centroid(ST_GeometryFromText('LINESTRING EMPTY'))

贡献者指南

技术栈
java
领域
databasebackend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaSQL geometry functions
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue references a fix in Velox (https://github.com/facebookincubator/velox/pull/15985). The Java implementation of ST Centroid likely lives in the presto geospatial module. Locate the ST Centroid function, add a check for empty geometry input, and return null as per ISO spec. Review the existing test cases for spatial functions to ensure proper coverage.