prestodb/presto

OutputMatcher should take a Collection rather than a List

Open

#22,756 创建于 2024年5月15日

在 GitHub 查看
 (3 评论) (0 反应) (1 负责人)Java (15,558 star) (5,240 fork)batch import
available-to-pickupgood first issueplanner

描述

com.facebook.presto.sql.planner.assertions.OutputMatcher should take a Collection rather than a List

Order is not important in this class so this is semantically correct, and I encountered a case where it would have been mildly more convenient to pass in a Set instead of a List.

贡献者指南

技术栈
java
领域
database
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaPresto codebase basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Locate the class OutputMatcher in the package com.facebook.presto.sql.planner.assertions. The goal is to change the method parameter type from List to Collection. Ensure that the change does not break any existing code or tests. Review the existing tests for OutputMatcher to confirm they still pass. Since an assignee is already set, check if there is any ongoing work or PRs linked to this issue.