preactjs/preact-compat

child visible property toggles from true to false without re-render

Open

#311 创建于 2017年2月28日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)JavaScript (952 star) (148 fork)batch import
help wanted

描述

In my test project: https://github.com/MichaelRando/preact-rollup-bootstrap pressing button 'Test Dialog' displays a test dialog, by virtue of setting the state variable to true and the Dialog's visible property is set to said state. Clicking off or closing the dialog is expected to hide the dialog's view. When using react & react-dom, the dialog appears and disappears as many times as the user could want, successfully. When using preact & preact-compat, the dialog appears successfully, but closing / setting the visible state false has no effect. The Dialog component is not re-rendering as React compatibility would expect. This is a super basic test; not sure why this is happening.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
React basicsPreact compatible components
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Investigate the dialog visibility toggle bug in preact compat by reviewing the 8 comments for debugging hints. The linked test project (github.com/MichaelRando/preact rollup bootstrap) reproduces the issue. Compare how preact compat handles child visibility vs. React. The compatibility layer has since moved to the main preact repo; check if the bug persists there and consider porting the fix.