pnp/cli-microsoft365

Bug: superseding rules works incorrectly

开放

#2,593 创建于 2021年7月16日

 (6 条评论) (0 个反应) (0 位负责人)TypeScript (399 个派生)auto 404
bughelp wantedkeep-open

仓库指标

星标
 (1,390 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Discussed in https://github.com/pnp/cli-microsoft365/discussions/2590

When upgrading SPFx project from 1.11 to 1.12, CLI won't suggest removing rush-stack-compiler 3.3. While the rule is there, it's superseded by installing rush-stack-compiler 3.7. The problem is, that currently superseding doesn't take into account the difference between installing and uninstalling the package. We need to think about how to handle it as currently superseding is handled centrally outside the rule.

One way could be to replace the array of superseded rule IDs with a method that takes a rule as an argument. That way, the rule could examine other rule's properties and return a bool true or false depending if the rule should be superseded or not.

贡献者指南