pmndrs/react-three-fiber

RFC: @react-three/eslint-plugin rules

Open

#2,701 创建于 2023年1月10日

在 GitHub 查看
 (15 评论) (10 反应) (0 负责人)TypeScript (25,748 star) (1,464 fork)batch import
help wantedrequest for commentsv10

描述

Aligning with our docs for general performance pitfalls and API usage around context (use R3F hooks within Canvas):

  • no-clone-in-frame-loop: Prefer creating temporary objects in global space and copy rather than clone in hot paths. This should be restricted to three.js classes to avoid collisions. https://github.com/pmndrs/react-three-fiber/pull/2710
  • no-fast-state: Don't set state within loops or continuous events (startTransition can be used if you must, this can be disabled for specific polling cases)
  • prefer-useloader: Prefer useLoader for suspense and caching rather than calling Loader.load or Loader.loadAsync in an effect. This will de-dup resources on both the CPU and GPU and avoid later expensive runtime compilation.

贡献者指南

技术栈
reacttypescriptjavascript
领域
developer experiencetooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic ESLint plugin knowledgeReact Three Fiber conceptsJavaScript/TypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the existing pitfalls documentation (https://docs.pmnd.rs/react three fiber/advanced/pitfalls) and the reference PR #2710 for the no clone in frame loop rule. Study ESLint plugin structures (e.g., ast, rule creation) and decide on rule names and messages. Consider adding tests and documentation.