plotly/falcon

Refactor Preview.react.js and Settings.react.js

Open

#362 创建于 2018年2月1日

在 GitHub 查看
 (15 评论) (1 反应) (0 负责人)JavaScript (5,093 star) (279 fork)batch import
discussiongood first issuehelp wantedrefactor

描述

cc/ @kcolton @chriddyp @tarzzz

I'm starting this discussion prompted by issues:

  • #360 (poor performance of code editor)
  • #361 (duplicated sql-schemas requests)

Although the code editor lives in CodeEditorField.react.js and the schema preview in TableTree.react.js, it's very likely that we'll have to touch code in their parent components Preview.react.js and Settings.react.js.

I'd like to use this issue to discuss any significant changes to Preview.react.js and Settings.react.js before creating a PR.

贡献者指南

技术栈
javascriptreact
领域
frontendperformance
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactJavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the performance issues described in #360 and #361. Review the code in Preview.react.js and Settings.react.js along with their child components CodeEditorField.react.js and TableTree.react.js. Identify how to eliminate duplicated SQL schema requests and improve code editor performance. Consider proposing a refactoring plan in this issue before coding.