plotly/falcon

Refactor Preview.react.js and Settings.react.js

Open

#362 创建于 2018年2月1日

在 GitHub 查看
 (15 评论) (1 反应) (0 负责人)JavaScript (279 fork)batch import
discussiongood first issuehelp wantedrefactor

仓库指标

Star
 (5,093 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

cc/ @kcolton @chriddyp @tarzzz

I'm starting this discussion prompted by issues:

  • #360 (poor performance of code editor)
  • #361 (duplicated sql-schemas requests)

Although the code editor lives in CodeEditorField.react.js and the schema preview in TableTree.react.js, it's very likely that we'll have to touch code in their parent components Preview.react.js and Settings.react.js.

I'd like to use this issue to discuss any significant changes to Preview.react.js and Settings.react.js before creating a PR.

贡献者指南