playcanvas/engine

BoundingBox, BoundingSphere, OrientedBox extra methods.

Open

#858 创建于 2017年2月22日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (8,878 star) (1,325 fork)batch import
enhancementgood first issue

描述

It worth finalizing consistency withing those three classes, so here is list of things to do:

BoundingBox

  1. Deprecate intersects and add another method intersectsBoundingBox which will have same functionality
  2. Add intersectsOrientedBox method
  3. Add center and halfExtents property reference

BoundingSphere

  1. Add intersectsBoundingBox method (calls box.intersectsBoundingSphere internally)
  2. Add intersectsOrientedBox method
  3. Add center and radius property reference

OrientedBox

  1. Add intersectsBoundingBox method (calls box.intersectsOrientedBox internally)
  2. Add intersectsOrientedBox method
  3. Add halfExtents property reference
  4. Property worldTransform has wrong reference

贡献者指南

技术栈
javascript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic 3D geometryJavaScriptFamiliarity with PlayCanvas engineUnderstanding of bounding volumes
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Locate the BoundingBox, BoundingSphere, and OrientedBox classes in the PlayCanvas engine codebase (likely in src/scene/). Review existing methods like intersects, intersectsBoundingSphere, and property references. For BoundingBox: deprecate intersects and add intersectsBoundingBox (same functionality), add intersectsOrientedBox, and add center and halfExtents property references. For BoundingSphere: add intersectsBoundingBox (calling box.intersectsBoundingSphere internally), add intersectsOrientedBox, and add center and radius property references. For OrientedBox: add intersectsBoundingBox (calling box.intersectsOrientedBox), add intersectsOrientedBox, add halfExtents property reference, and fix the worldTransform property reference. Ensure consistency and follow existing coding patterns. Check for any existing implementations or partial work.