pinojs/pino

bindings() and setBindings() are not present in the browser version of pino

Open

#1,177 创建于 2021年10月20日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (13,157 star) (839 fork)batch import
enhancementgood first issue

描述

Hello!

I was attempting to use pino in the browser today and discovered that .bindings() is undefined. Additionally, .setBindings() is also undefined, but it's also undocumented in general (is it officially part of the API?).

I looked into adding this to browser.js but I'd definitely need some guidance before proceeding. For example, I'm not sure if bindings changes cascade through child loggers or if they are fixed at the time of child creation, for example.

贡献者指南

技术栈
javascript
领域
backendfrontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
needs maintainer response
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
familiarity with pino's APIknowledge of child logger behavior
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Start by examining the browser.js file in the repository to understand how the browser logger is implemented. Check the documentation for bindings() and setBindings() in the Node.js version. Look at how child loggers are created and if bindings are mutable. The issue author requested guidance, so it would be helpful to review any comments for additional context.
bindings() and setBindings() are not present in the browser version of pino · pinojs/pino#1177 | Good First Issue