pingcap/tidb

Analyze process should stop once the table is truncated or dropped

Open

#9,300 创建于 2019年2月14日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Go (40,090 star) (6,186 fork)batch import
challenge-programhelp wantedsig/executiontype/feature-request

描述

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

Constructing a large table whose analyze process would last long. Analyze the table then drop it. Then GC is invoked and sends UnsafeDestroyRange to TiKV to clean up the data of this table. But during the cleanup, the analyze process would read incompletely data which leads to TiKV panic.

  1. What did you expect to see?

Analyze process should stop once the table is truncated or dropped.

  1. What did you see instead?

From TiKV log, we can see that the table is already truncated but the analyze process is still in working.

2019/02/13 20:27:50.999 INFO gc_worker.rs:345: unsafe destroy range start_key: t\200\000\000\000\000\000\000\377\201\000\000\000\000\000\000\000\370, end_key: t\200\000\000\000\000\000\000\377\202\000\000\000\000\000\000\000\370 finished cleaning up all, cost time 2.700992685s
2019/02/13 20:27:55.281 INFO analyze.rs:127: analyze handle column range [start: "t\200\000\000\000\000\000\000\201_r\200\000\000\000\006m\206\312" end: "t\200\000\000\000\000\000\000\201_r\200\000\000\000\006s\027|"]
  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?

v2.1.1

SIG slack channel

#sig-exec

Score

300

Mentor

  • @lzmhhh123

贡献者指南

技术栈
go
领域
backenddatabase
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingBasic understanding of TiDB architecture
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
The issue describes a bug where the analyze process continues after a table is truncated or dropped, leading to TiKV panic. The logs indicate that the unsafe destroy range is completed but the analyze handle column range is still active. The fix should ensure analyze jobs are cancelled upon table drop/truncation. Relevant files include `gc worker.rs` and `analyze.rs`. The mentor @lzmhhh123 may provide further guidance. A possible approach involves checking table existence before processing analyze ranges or hooking into table drop events.