pingcap/tidb

Refine domain.Close logic.

Open

#8,696 创建于 2018年12月15日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Go (40,090 star) (6,186 fork)batch import
help wantedsig/sql-infratype/enhancement

描述

Feature Request

Is your feature request related to a problem? Please describe: Currently, domain.Close doesn't stop schemaValidator, there may have problem for the running client requests to commit with outdated schema.

We should clear call do.SchemaValidator.Stop() when `domain.Close().

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

贡献者指南

技术栈
go
领域
backenddatabase
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
GoTiDB codebase familiarity
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Examine the domain.Close method in the Go source code, likely in the 'domain' package. Identify where schemaValidator is used and ensure a call to schemaValidator.Stop() is added within domain.Close. The issue provides a clear requirement; you can look at existing code to find the exact location and implement the fix.