pingcap/tidb

cast string as time caused an "invalid time format" error, not compatible with mysql

Open

#5,340 创建于 2017年12月7日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Go (40,090 star) (6,186 fork)batch import
component/expressionhelp wantedpriority/P4sig/executiontype/compatibility

描述

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
./gentest.pl --dsn dbi:mysql:host=127.0.0.1:port=4000:user=root:database=test --grammar=conf/subquery_semijoin.yy --gendata --thread=1

SELECT  OUTR . `col_datetime_nokey` AS X FROM C AS OUTR WHERE ( OUTR . `col_int_nokey` , OUTR . `pk` ) IN ( SELECT DISTINCT INNR . `col_int_nokey` AS X , INNR . `col_int_key` AS Y FROM CC AS INNR2 LEFT JOIN CC AS INNR ON ( INNR2 . `col_time_key` <> INNR . `col_date_key` ) WHERE INNR . `col_int_key` >= INNR . `pk` OR NOT OUTR . `pk` < 0 ORDER BY INNR . `col_varchar_key` ) AND OUTR . `pk` < 8 HAVING X = '18:47:12' ORDER BY OUTR . `col_time_nokey` , OUTR . `pk`

createtable.txt 2. What did you expect to see?

no error

  1. What did you see instead?
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/types/time.go:35: invalid time format
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/types/time.go:1363: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/types/time.go:1343: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/types/time.go:1398: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/types/time.go:492: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/types/time.go:1252: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/expression/builtin_cast.go:989: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/expression/builtin_compare.go:1892: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/expression/builtin_compare.go:1787: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/expression/scalar_function.go:215: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/expression/expression.go:105: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/executor.go:593: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/join.go:718: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/join.go:824: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/sort.go:116: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/executor.go:498: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/adapter.go:80: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/server/conn.go:809: 
/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/server/conn.go:762:
  1. What version of TiDB are you using (tidb-server -V)? 648e51d19e51120e9158f6333c060f17260b7ea6

贡献者指南

技术栈
gosqlmysql
领域
backenddatabase
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Gotime handlingMySQL type casting
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
15
研究方向
Investigate the error originating from types/time.go:35 where an invalid time format is thrown. Compare MySQL's behavior for casting string to time with TiDB's implementation. The stack trace points to files in types/time.go and expression/builtin cast.go. Check if the issue has been addressed in later commits by searching for related changes in those files. The query involves a HAVING clause with a time string comparison; ensure TiDB handles time literals like '18:47:12' correctly in such contexts.