pingcap/tidb

executor.Next() should not call chid.Open() or child.Close()

Open

#4,983 创建于 2017年11月2日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)Go (40,090 star) (6,186 fork)batch import
help wanted

描述

calling Open() or Close() during Next() makes our executors un-maintainable, for example, if we comment out the following lines then make test, our ut failes ... https://github.com/pingcap/tidb/blob/0616a2fd1511e2206086c212261d93b1106605c7/executor/executor.go#L345

or https://github.com/pingcap/tidb/blob/0616a2fd1511e2206086c212261d93b1106605c7/executor/join.go#L88

Open is used to initialize executors and allocate resources for every executor Close is used to deallocate the resource adopted by every executor, avoid memory leak

贡献者指南

技术栈
go
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingunderstanding of executor lifecycle
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Examine the references in executor/executor.go and executor/join.go to understand the current pattern. Determine the correct places to call Open and Close without violating the Next contract. Ensure that existing tests pass after the refactoring, as noted in the issue that tests fail with current code. Consider the wider executor hierarchy to maintain consistency.
executor.Next() should not call chid.Open() or child.Close() · pingcap/tidb#4983 | Good First Issue