pingcap/tidb

use monotonic time directly instead of Go time in somewhere

Open

#32,121 创建于 2022年2月7日

在 GitHub 查看
 (6 评论) (3 反应) (1 负责人)Go (6,186 fork)batch import
help wantedtype/enhancementtype/performance

仓库指标

Star
 (40,090 star)
PR 合并指标
 (平均合并 14天 4小时) (30 天内合并 346 个 PR)

描述

Enhancement

In TiDB, we heavily use Go time.Now to calculate the duration of some operations, e.g. prometheus Histogram, query time, etc.

For time.Now, this function will call walltime and nanotime, but in the above scenario, we only need to call nanotime(monotonic clock) to calculate the duration.

import _ "unsafe"
//go:noescape
//go:linkname nanotime runtime.nanotime
func nanotime() int64

func Now() time.Duration {
	return time.Duration(nanotime())
}

Here is a simple implementation for Nanotime,


func BenchmarkTime1(b *testing.B) {
	for i := 0; i < b.N; i++ {
		time.Now()
	}
}

func BenchmarkTime2(b *testing.B) {
	for i := 0; i < b.N; i++ {
		Now()
	}
}

The benchmark result is:

BenchmarkTime1-8          	17705235	        65.90 ns/op
BenchmarkTime2-8          	38601799	        29.68 ns/op

贡献者指南