pingcap/tidb

*: a better design for concurrent access of GlobalConfig

Open

#30,366 创建于 2021年12月3日

在 GitHub 查看
 (3 评论) (2 反应) (0 负责人)Go (6,186 fork)batch import
help wantedsig/sql-infratype/enhancement

仓库指标

Star
 (40,090 star)
PR 合并指标
 (平均合并 14天 4小时) (30 天内合并 346 个 PR)

描述

Enhancement

Currently, the GlobalConfig is loaded from the configuration file and can be modified('dynamic config') after that, several fields are wrapped with an atomic operation helper to avoid data race issues, for example:

But it can be vulnerable, for example:

https://github.com/pingcap/tidb/issues/30345 is introduced by #29247 but it is really hard for the developers to realize the race issue. In order to solve it, an atomic wrapper is introduced in https://github.com/pingcap/tidb/pull/30346.

IMO this may easily happen before we find a systematic way to solve it, possible alternatives are:

贡献者指南