pingcap/tidb

Use a better error message for some error in window function.

Open

#10,551 创建于 2019年5月21日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Go (40,090 star) (6,186 fork)batch import
help wantedpriority/P4type/compatibilitytype/usability

描述

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
SELECT i, j, SUM(i+j) OVER (ORDER BY jj DESC ROWS UNBOUNDED PRECEDING) foo FROM t;

jj is a column name from table t.

  1. What did you expect to see?
Unknown column 'jj' in 'window order by'
  1. What did you see instead?
Unknown column 'jj' in 'field list'
  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?

贡献者指南

技术栈
gosql
领域
database
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingSQL window functions
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Find the code that generates the error message for 'Unknown column' in window order by clauses. The issue shows the current error is 'Unknown column 'jj' in 'field list'' but the expected is 'Unknown column 'jj' in 'window order by''. Locate the relevant error handling logic in the TiDB source code, likely in the planner or executor for window functions. Change the error message to reflect the context of the window order by clause. Ensure tests pass.