php/doc-en

Functions signatures are documented as can return FALSE, but return value documentation disagrees

开放

#859 创建于 2021年8月18日

 (1 条评论) (0 个反应) (0 位负责人)XML (882 个派生)auto 404
QAgood first issue

仓库指标

星标
 (596 个星标)
PR 合并指标
 (平均合并 99天 23小时) (30 天内合并 90 个 PR)

描述

This is a generalization of the issue https://github.com/php/doc-en/issues/856. Thank you to @cmb69 on that one.

I have gone out to find every instance of a PHP function which is defined as possibly returning a false value but where the return value documentation does not mention the possibility of a false return value.

I created this list of candidates using:

grep --files-with-matches --recursive '<type class="union"><type>\w\+</type><type>false</type></type>' . > ~/Desktop/canoutputfalse

grep --files-with-matches --recursive '&return.falseforfailure;' . > ~/Desktop/falseforfailure

cat ~/Desktop/canoutputfalse ~/Desktop/falseforfailure ~/Desktop/falseforfailure | sort | uniq -u > ~/Desktop/reviewthese

code $(cat ~/Desktop/reviewthese)

And manually reviewing each one.

This is part of my efforts in https://github.com/php/doc-en/pull/858. And please ftlog review and approve that PR first so it can be merged without sitting around!


The list

My understanding is that this list is comprehensive, I don't think you will find any more that could fit in this category.

Work plan

For each one of these in the list, we should read the implementation and either:

  1. If the function CANNOT return false, then remove the false in the definition at top.
  2. If the function CAN return false, then explain this in the return value section.

贡献者指南