peers/peerjs

Error expected on DataConnection when not establishing a connection

Open

#924 创建于 2022年2月17日

在 GitHub 查看
 (5 评论) (7 反应) (0 负责人)TypeScript (11,580 star) (1,406 fork)batch import
clientfeaturehelp wanted

描述

When a DataConnection fails to establish, for example, due to connecting to an invalid ID or to one's own ID, I would expect the dataConnection.on('error', () => {...}) callback to be executed. Instead, only peer.on('error', () => {}) catches such kinds of errors. This is especially annoying when you want to for example connect to multiple peers at once since we cannot know which one has failed to connect, making it hard to tell the user which peer(s) has issues.

贡献者指南

技术栈
typescriptjavascript
领域
api
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of WebRTCFamiliarity with PeerJS API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the DataConnection class in the source code (likely `src/dataconnection.ts`). Understand how the base Peer class emits errors and replicate that pattern in DataConnection. Ensure that errors during connection setup (e.g., invalid ID or connecting to self) trigger the new event. Update the TypeScript typings and write tests for the new event.